You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
add escaped structured GitHub annotations, grouping, and PASS/WARN/ERROR summary output;
document the presentation contract and add black-box regression coverage.
Contract boundaries
wright-driver remains the owner of semantic execution, typed wright-result/v1 envelopes, diagnostics, exit codes, and artifact file I/O. The CLI presentation layer consumes those structured results.
JSON mode emits only one envelope to stdout. Compile/convert text mode emits only the source artifact, byte-for-byte; compile -o emits no artifact to stdout. GitHub workflow commands are emitted on the diagnostic stream, while artifact stdout remains pure; GITHUB_STEP_SUMMARY is used when available.
Follow-up commit 7c25fe3 fixes the first CI failure. Root cause: the default black-box run() helper inherited GitHub runner CI/GITHUB_ACTIONS, so existing text-contract tests unintentionally selected the GitHub Actions renderer. The helper now clears presentation environment variables; explicit environment-matrix tests still inject them. Reproduced with CI=true GITHUB_ACTIONS=true cargo test --locked -p wright-cli --all-targets --all-features: 63 passed. Checks are being rerun.
Final CI evidence for head 7c25fe38dc2aa884dac02cc1da6b331a3d1062dd: all 13 checks pass, including Rust quality (stable and 1.85.0), macOS/Ubuntu/Windows distribution validation, LPP integration, native/reference differentials, OverPy compatibility, OSTW baselines/differential, and v1 release gates. The Draft PR is ready for review/merge.
PM audit blockers resolved in head 1641f9549c20e56797429c38cd36737d43dc7d56: (1) GHA summary status now aggregates structured diagnostics and findings by highest severity — error=ERROR, warning=WARN, info/notice-only=PASS — with regression coverage for all three cases and both sources; (2) added the Wright CLI GitHub Actions smoke job. Its real hosted-runner execution passed, proving auto renderer detection from actual GITHUB_ACTIONS, clean artifact stdout, workflow grouping, and GITHUB_STEP_SUMMARY PASS output. All 13 PR checks pass. PR remains Draft for PM/QA merge review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
wrightargv/help layer with oneclapcommand model;Contract boundaries
wright-driverremains the owner of semantic execution, typedwright-result/v1envelopes, diagnostics, exit codes, and artifact file I/O. The CLI presentation layer consumes those structured results.JSON mode emits only one envelope to stdout. Compile/convert text mode emits only the source artifact, byte-for-byte;
compile -oemits no artifact to stdout. GitHub workflow commands are emitted on the diagnostic stream, while artifact stdout remains pure;GITHUB_STEP_SUMMARYis used when available.Verification
cargo fmt --all -- --checkgit diff --checkcargo check --workspace --all-targetscargo clippy --workspace --all-targets -- -D warningscargo test --locked -p wright-cli --all-targets --all-features— 63 passedcargo test --workspace— passedFixes #164